-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: normalize the open api version #3551
Conversation
7f998e1
to
5f5bc20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see how we handle the scenario when open api version mismatches between definition body and api property.
Basically when
|
Issue #, if available
In Serverless Api, if
OpenApiVersion
is different fromopenapi
value in DefinitionBody, SAM will missconfigure the updated openApi definition body.Description of changes
When
openapi
is in the DefinitionBody, we use that value instead ofOpenApiVersion
property in the resource.Description of how you validated changes
Transform tests covering both cases.
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam init
through aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.