-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added VersionDescription property on Serverless::Function #835
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #835 +/- ##
===========================================
+ Coverage 94.23% 94.56% +0.33%
===========================================
Files 67 67
Lines 2688 2834 +146
Branches 478 508 +30
===========================================
+ Hits 2533 2680 +147
- Misses 80 82 +2
+ Partials 75 72 -3
Continue to review full report at Codecov.
|
Hey! This looks great so far. Could you add this property into one of the E2E tests? The one at the path After that, this should be good to go! Thank you for contributing! |
…rless::Function Resource
Hey! @keetonian , Thanks for the response. I have updated the end to end tests as per your suggestion. please let me know if there are any other updates needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Thank you for the contribution! Just add the new property to the documentation and we'll be able to merge it in.
@Buffer0x7cd Documentation- you have the file correct. You should add the property and a short description about it to https://github.com/awslabs/serverless-application-model/blob/develop/versions/2016-10-31.md#awsserverlessfunction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just make the documentation update @keetonian mentioned and this will be good to go!
@jlhood I have added the VersionDescription Property in the documentation as requested. please feel free to review this PR. |
Issue #, if available:
#823
Description of changes:
This PR Add an Additional
VersionDescription
property on Serverless::Function.Description of how you validated changes:
I validated the changes by creating an instance of
SamFunction
and then setting theVersionDescription
property of the instance. after this i called theto_cloudformation
method ofSamFunction
and validated that the string passed inVersionDescription
is proprly set on the instance ofLambdaVersion
class underDescription
property.Checklist:
make pr
passesVersion/2016-10-31
. but i thought asked this explicitly will be better.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.