Release 1.5.2 (#385)

* fix: Use single value headers for HTTP API response (#377) Parametrized the use of the single value headers for the response writer to support the v2 proxy schema for HTTP API * fix: Updated HTTP API handler constructor (#377) Changed default httpApiV2 constructor for the handler in all the framework implementations * fix: Switched to non-mime encoder for respponse (#339)
aws · Oct 6, 2020 · 5c4ca2b · 5c4ca2b
1 parent edf11fe
commit 5c4ca2b
Show file tree

Hide file tree

Showing 6 changed files with 47 additions and 7 deletions.
diff --git a/...va/com/amazonaws/serverless/proxy/internal/servlet/AwsProxyHttpServletResponseWriter.java b/...va/com/amazonaws/serverless/proxy/internal/servlet/AwsProxyHttpServletResponseWriter.java
@@ -19,11 +19,14 @@
 import com.amazonaws.serverless.proxy.internal.testutils.Timer;
 import com.amazonaws.serverless.proxy.model.AwsProxyRequest;
 import com.amazonaws.serverless.proxy.model.AwsProxyResponse;
+import com.amazonaws.serverless.proxy.model.Headers;
 import com.amazonaws.services.lambda.runtime.Context;
 
 import javax.ws.rs.core.Response;
 
 import java.util.Base64;
+import java.util.HashMap;
+import java.util.Map;
 
 
 /**
@@ -32,6 +35,16 @@
  */
 public class AwsProxyHttpServletResponseWriter extends ResponseWriter<AwsHttpServletResponse, AwsProxyResponse> {
 
+    private boolean writeSingleValueHeaders;
+
+    public AwsProxyHttpServletResponseWriter() {
+        this(false);
+    }
+
+    public AwsProxyHttpServletResponseWriter(boolean singleValueHeaders) {
+        writeSingleValueHeaders = singleValueHeaders;
+    }
+
     //-------------------------------------------------------------
     // Methods - Implementation
     //-------------------------------------------------------------
@@ -47,13 +60,16 @@ public AwsProxyResponse writeResponse(AwsHttpServletResponse containerResponse,
             if (!isBinary(containerResponse.getContentType()) && isValidUtf8(containerResponse.getAwsResponseBodyBytes())) {
                 responseString = containerResponse.getAwsResponseBodyString();
             } else {
-                responseString = Base64.getMimeEncoder().encodeToString(containerResponse.getAwsResponseBodyBytes());
+                responseString = Base64.getEncoder().encodeToString(containerResponse.getAwsResponseBodyBytes());
                 awsProxyResponse.setBase64Encoded(true);
             }
 
             awsProxyResponse.setBody(responseString);
         }
         awsProxyResponse.setMultiValueHeaders(containerResponse.getAwsResponseHeaders());
+        if (writeSingleValueHeaders) {
+            awsProxyResponse.setHeaders(toSingleValueHeaders(containerResponse.getAwsResponseHeaders()));
+        }
 
         awsProxyResponse.setStatusCode(containerResponse.getStatus());
 
@@ -65,6 +81,17 @@ public AwsProxyResponse writeResponse(AwsHttpServletResponse containerResponse,
         return awsProxyResponse;
     }
 
+    private Map<String, String> toSingleValueHeaders(Headers h) {
+        Map<String, String> out = new HashMap<>();
+        if (h == null || h.isEmpty()) {
+            return out;
+        }
+        for (String k : h.keySet()) {
+            out.put(k, h.getFirst(k));
+        }
+        return out;
+    }
+
     private boolean isBinary(String contentType) {
         if(contentType != null) {
             int semidx = contentType.indexOf(';');

diff --git a/...com/amazonaws/serverless/proxy/internal/servlet/ServletLambdaContainerHandlerBuilder.java b/...com/amazonaws/serverless/proxy/internal/servlet/ServletLambdaContainerHandlerBuilder.java
@@ -110,7 +110,7 @@ public Builder defaultProxy() {
     public Builder defaultHttpApiV2Proxy() {
         initializationWrapper(new InitializationWrapper())
                 .requestReader((RequestReader<RequestType, ContainerRequestType>) new AwsHttpApiV2HttpServletRequestReader())
-                .responseWriter((ResponseWriter<AwsHttpServletResponse, ResponseType>) new AwsProxyHttpServletResponseWriter())
+                .responseWriter((ResponseWriter<AwsHttpServletResponse, ResponseType>) new AwsProxyHttpServletResponseWriter(true))
                 .securityContextWriter((SecurityContextWriter<RequestType>) new AwsHttpApiV2SecurityContextWriter())
                 .exceptionHandler((ExceptionHandler<ResponseType>) new AwsProxyExceptionHandler())
                 .requestTypeClass((Class<RequestType>) HttpApiV2ProxyRequest.class)

diff --git a/...sey/src/main/java/com/amazonaws/serverless/proxy/jersey/JerseyLambdaContainerHandler.java b/...sey/src/main/java/com/amazonaws/serverless/proxy/jersey/JerseyLambdaContainerHandler.java
@@ -116,7 +116,7 @@ public static JerseyLambdaContainerHandler<HttpApiV2ProxyRequest, AwsProxyRespon
                 HttpApiV2ProxyRequest.class,
                 AwsProxyResponse.class,
                 new AwsHttpApiV2HttpServletRequestReader(),
-                new AwsProxyHttpServletResponseWriter(),
+                new AwsProxyHttpServletResponseWriter(true),
                 new AwsHttpApiV2SecurityContextWriter(),
                 new AwsProxyExceptionHandler(),
                 jaxRsApplication);

diff --git a/...spark/src/main/java/com/amazonaws/serverless/proxy/spark/SparkLambdaContainerHandler.java b/...spark/src/main/java/com/amazonaws/serverless/proxy/spark/SparkLambdaContainerHandler.java
@@ -132,7 +132,7 @@ public static SparkLambdaContainerHandler<HttpApiV2ProxyRequest, AwsProxyRespons
         SparkLambdaContainerHandler<HttpApiV2ProxyRequest, AwsProxyResponse> newHandler = new SparkLambdaContainerHandler<>(HttpApiV2ProxyRequest.class,
                 AwsProxyResponse.class,
                 new AwsHttpApiV2HttpServletRequestReader(),
-                new AwsProxyHttpServletResponseWriter(),
+                new AwsProxyHttpServletResponseWriter(true),
                 new AwsHttpApiV2SecurityContextWriter(),
                 new AwsProxyExceptionHandler(),
                 new LambdaEmbeddedServerFactory());

diff --git a/...ainer-springboot2/src/test/java/com/amazonaws/serverless/proxy/spring/ServletAppTest.java b/...ainer-springboot2/src/test/java/com/amazonaws/serverless/proxy/spring/ServletAppTest.java
@@ -23,8 +23,7 @@
 import java.util.Collection;
 import java.util.stream.Collectors;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.*;
 
 @RunWith(Parameterized.class)
 public class ServletAppTest {
@@ -192,4 +191,18 @@ public void springExceptionMapping_throw404Ex_expectMappedTo404() {
         assertNotNull(resp);
         assertEquals(404, resp.getStatusCode());
     }
+
+    @Test
+    public void echoMessage_populatesSingleValueHeadersForHttpApiV2() {
+        AwsProxyRequestBuilder req = new AwsProxyRequestBuilder("/message", "POST")
+                .header(HttpHeaders.CONTENT_TYPE, "application/json;v=1")
+                .header(HttpHeaders.ACCEPT, "application/json;v=1")
+                .body(new MessageData("test message"));
+        AwsProxyResponse resp = handler.handleRequest(req, lambdaContext);
+        if ("HTTP_API".equals(type)) {
+            assertNotNull(resp.getHeaders());
+        } else {
+            assertNull(resp.getHeaders());
+        }
+    }
 }
diff --git a/...2/src/main/java/com/amazonaws/serverless/proxy/struts2/Struts2LambdaContainerHandler.java b/...2/src/main/java/com/amazonaws/serverless/proxy/struts2/Struts2LambdaContainerHandler.java
@@ -65,7 +65,7 @@ public static Struts2LambdaContainerHandler<HttpApiV2ProxyRequest, AwsProxyRespo
                 HttpApiV2ProxyRequest.class,
                 AwsProxyResponse.class,
                 new AwsHttpApiV2HttpServletRequestReader(),
-                new AwsProxyHttpServletResponseWriter(),
+                new AwsProxyHttpServletResponseWriter(true),
                 new AwsHttpApiV2SecurityContextWriter(),
                 new AwsProxyExceptionHandler());
     }