Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Built in support for Struts2 based lambda functions #149

Closed
jogep opened this issue May 9, 2018 · 4 comments
Closed

Built in support for Struts2 based lambda functions #149

jogep opened this issue May 9, 2018 · 4 comments
Labels
enhancement
Milestone
Release 1.2

Comments

@jogep
Copy link
Contributor

jogep commented May 9, 2018

  • Framework version: 2.5.16
  • Implementations: Struts2

Scenario

I created a similar Struts2 Handler like for Spring based Lambdas. This functionality could mayby directly included into this project?

Struts2 Plugin:
https://github.com/struts-community-plugins/struts2-cloud-support/tree/master/struts2-aws-lambda-support-plugin

Struts2 Lambda Handler Implementation:
https://github.com/struts-community-plugins/struts2-cloud-support/tree/master/struts2-aws-lambda-support-plugin/src/main/java/org/apache/struts2/aws/lambda/support/handler

Expected behavior

Support Struts2 as well.

Actual behavior

Only Jersey and Spring are supported.
@sapessi
Copy link
Collaborator

sapessi commented May 9, 2018

Hi @jogep - looks really good. We'd be happy to include this in the framework to give official Struts2 support. Can you update it to work with the latest version of the framework and send us a pull request. We can do code review and request changes in the pull request.

@jogep
Copy link
Contributor Author

jogep commented May 14, 2018

Hi @sapessi , thank you for the review and feedback, I will prepare a PR asap.

jogep added a commit to jogep/aws-serverless-java-container that referenced this issue Jun 20, 2018
@jogep
Provide first module to run Struts2 based applications as AWS Lambda …
a3d63aa 
…functions

aws#149
@jogep jogep mentioned this issue Jun 20, 2018
Closed
@jogep
Copy link
Contributor Author

jogep commented Jun 20, 2018

Hi @sapessi , I created the PR for this feature request.

#159

@sapessi sapessi added this to the Release 1.2 milestone Jun 20, 2018
jogep added a commit to jogep/aws-serverless-java-container that referenced this issue Jun 20, 2018
@jogep
Remove optional from struts2-core dependency and remove duplicate dep…
69306ce 
…endency

aws#149
aws#159
jogep added a commit to jogep/aws-serverless-java-container that referenced this issue Aug 18, 2018
@jogep
Add link to Apache Struts project and to quick start guide for lambda…
6af0022 
…s based on Struts2

aws#149
jogep added a commit to jogep/aws-serverless-java-container that referenced this issue Aug 18, 2018
@jogep
Correct link for quick start guide for lambdas based on Struts2
fbf4810 
aws#149
jogep added a commit to jogep/aws-serverless-java-container that referenced this issue Aug 18, 2018
@jogep
Correct link for quick start guide for lambdas based on Struts2
cd9917f 
aws#149
jogep added a commit to jogep/aws-serverless-java-container that referenced this issue Aug 23, 2018
@jogep
Switch to latest Struts2 version 2.5.17 with important security fixes
e9e474f 
aws#149
jogep added a commit to jogep/aws-serverless-java-container that referenced this issue Sep 8, 2018
@jogep
Provide a pet store example for lambdas based on apache struts2 frame…
85c9a4a 
…work

aws#149
jogep added a commit to jogep/aws-serverless-java-container that referenced this issue Sep 10, 2018
@jogep
Correct some typos
c3de905 
aws#149
jogep added a commit to jogep/aws-serverless-java-container that referenced this issue Sep 10, 2018
@jogep
Adjust struts2 pet store log4j config
d48ca49 
aws#149
jogep added a commit to jogep/aws-serverless-java-container that referenced this issue Sep 10, 2018
@jogep
Provide archetype for struts2 based lambdas
1d89996 
aws#149
jogep added a commit to jogep/aws-serverless-java-container that referenced this issue Oct 17, 2018
@jogep
Switch to latest Struts2 version 2.5.18
7e0a5ab 
aws#149
@sapessi
Copy link
Collaborator

sapessi commented Oct 19, 2018

Merged in core branch. Resolving.

@sapessi sapessi closed this as completed Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Release 1.2
Development

No branches or pull requests
2 participants
@jogep @sapessi