Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast exception when start spring container #225

Closed
isczh opened this issue Dec 29, 2018 · 3 comments
Closed

Cast exception when start spring container #225

isczh opened this issue Dec 29, 2018 · 3 comments

Comments

@isczh
Copy link

isczh commented Dec 29, 2018

  • Framework version: 1.3
  • Implementations: Spring

Scenario

https://github.com/awslabs/aws-serverless-java-container/blob/97f4d3034ef9a84db0950ef36f248817a3618121/aws-serverless-java-container-spring/src/main/java/com/amazonaws/serverless/proxy/spring/LambdaSpringApplicationInitializer.java#L146

This listener will also listen refresh event and cause a cast exception. Even though it can be catch by spring 5(leave a debug log), but in lower version will cause error. And I think servletRequestHandledEvent is not invoked, we don't have to cast it here.

@sapessi
Copy link
Collaborator

sapessi commented Jan 11, 2019

I expected the application listener to be triggered only for the request handled events - otherwise what's the point of the generic there? Any idea how to avoid this? Should I have a separate listener for the refresh?

@sapessi
Copy link
Collaborator

sapessi commented Feb 12, 2019

I'm going to remove the listener altogether as it is no longer required for the response latch to be release. All unit tests still pass.

@sapessi
Copy link
Collaborator

sapessi commented Feb 26, 2019

Closing since version 1.3.1 is out.

@sapessi sapessi closed this as completed Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants