Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency to Apache HttpCore #394

Closed
joain946 opened this issue Dec 4, 2020 · 1 comment
Closed

Remove dependency to Apache HttpCore #394

joain946 opened this issue Dec 4, 2020 · 1 comment
Assignees
Milestone

Comments

@joain946
Copy link

joain946 commented Dec 4, 2020

Serverless Java Container version: 1.5.2

Implementations: Jersey

Framework version: Jersey 2.30.1

Frontend service: HTTP API

Deployment method: SAM

Scenario

I want to minimize the number of dependencies used by my Lambda. Apache HttpCore is used in four classes, three of these are only used for testing. The fourth class is the AwsHttpServletRequest which only instantiates one class from Apache HttpCore but never uses it: https://github.com/awslabs/aws-serverless-java-container/blob/4380cc05fb96ccc61f8a76ff6f6381bb3ab75260/aws-serverless-java-container-core/src/main/java/com/amazonaws/serverless/proxy/internal/servlet/AwsHttpServletRequest.java#L110

Expected behavior

I want to be able to exclude Apache HttpCode ("httpcomponents-core") in my pom file.

Actual behavior

The class is needed.

@deki deki self-assigned this Jul 22, 2021
@deki
Copy link
Collaborator

deki commented Jul 23, 2021

Thanks for reporting this issue. For now I've removed the unused BasicHeaderValueParser and marked the dependency as optional in the pom.
In the future we could move AwsProxyRequestBuilder to a separate test-jar.

@deki deki added this to the Release 1.6 milestone Jul 23, 2021
jogep pushed a commit to jogep/aws-serverless-java-container that referenced this issue Jul 24, 2021
@deki deki closed this as completed Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants