Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

com.amazonaws.serverless.proxy.internal.servlet.AwsHttpServletRequest constructor is package private #422

Closed
adrian-baker opened this issue Aug 4, 2021 · 2 comments
Closed

com.amazonaws.serverless.proxy.internal.servlet.AwsHttpServletRequest constructor is package private #422

adrian-baker opened this issue Aug 4, 2021 · 2 comments
Assignees
@deki
Milestone
Release 1.7

Comments

@adrian-baker
Copy link

Based on the comments in this class, I believe it's intended to have protected access, which would allow it to be extended by classes outside this package (eg if implementing custom request/response data types other than API GW requests).
@deki
Copy link
Collaborator

deki commented Sep 6, 2021

Hi Adrian,
sorry for the late feedback. We can change it to protected. Do you want to create a PR for this? Otherwise I can make the change.

@deki deki self-assigned this Dec 29, 2021
@deki deki added this to the Release 1.7 milestone Dec 30, 2021
deki added a commit that referenced this issue Dec 30, 2021
@deki
Change AwsHttpServletRequest constructor to protected to allow extens…
8382bcc 
…ion (#422)
@deki
Copy link
Collaborator

deki commented Dec 30, 2021

I've just commited the change, will be part of the next release.

@deki deki closed this as completed Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deki deki

Labels
None yet
Projects
None yet
Milestone
Release 1.7
Development

No branches or pull requests
2 participants
@deki @adrian-baker