Jersey switch to servlets and FindBugs pass #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sapessi
commented
Jan 16, 2018
sapessi
commented
- Changes the Jersey implementation to use the core servlet module behind the scenes. This helps address Jersey HttpServletResponse Injection #62.
- Added FindBugs with security plugin to build process. Lots of small changes all around to comply with FindBug's rules.
…sts and responses as underlying objects. This solves #62 and simplifies writers and readers by condensing everything in the servlet implementation
…dler in the filter constructor (absorbed by Lambda) and not in the filter init method
…tions. Added Timer enabled to all samples. Removed POJO handler from samples since we recommend the stream handler
|
@sapessi Why did you add FindBugs and not SpotBugs? FindsBugs appears to be dead and SportBugs is the active fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.