Renamed SpringLambdacontainerHandler to SpringLambdaContainerHandler #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I totally missed this. Can you confirm that the unit tests still run ok. |
|
Also, I see in your spring boilerplate project that you created your own WebApplicationInitializer, would it make sense to let you pass an initializer to the container handler class instead of having our own in the background? |
|
Yes can confirm project still builds and all tests pass. |
|
In regard to the WebApplicationInitializer, that could work but I'm not sure just yet. Need to spend more time getting familiar with this library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.