Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Fixes issue where headers were treated as case sensitive after deserialization. #216

Closed
wants to merge 1 commit into from

Conversation

eirikjak
Copy link
Contributor

This bug seems to have been introduced when the MultiValuedTreeMap was added to support multi valued headers.

The bug:
When the MultiValuedTreeMap used for the multiValueHeaders property on AwsProxyRequest is deserialized the default constructor is used. The result is that the headers keys are treated as case sensitive because the String.CASE_INSENSITIVE_ORDER comparator is not used for the underlying TreeMap.

sapessi added a commit that referenced this pull request Dec 22, 2018
@sapessi sapessi added this to the Release 1.3 milestone Dec 22, 2018
@sapessi sapessi added the bug label Dec 22, 2018
@sapessi
Copy link
Collaborator

sapessi commented Dec 22, 2018

Thank you! I've merged the changes in the core branch where I'm working on the next release.

@sapessi sapessi closed this Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants