Move afterburner registration to dedicated method

[geoand]

Description of changes:

This makes it a lot easier for frameworks that want
to use the module in GraalVM, to exclude Afterburner
(which does not work in GraalVM native image because
it generated classes at runtime)

By submitting this pull request

• [ x ] I confirm that my contribution is made under the terms of the Apache 2.0 license.
• [ x ] I confirm that I've made a best effort attempt to update all relevant documentation.

[sapessi]

Hi @geoand, could you explain here why moving the afterburner registration to a separate static method helps with GraalVM support? Isn't it executed anyway when GraalVM starts the application at compile time? I would like to keep the full explanation in this PR for tracking purposes.

If you don't mind, I'll merge this PR to the graalvm branch rather than master. I have been running some experiments there.

[geoand]

Sure thing @sapessi.

Basically by having a dedicated method, it is super easy for a framework like Quarkus to provide a GraalVM substitution that simply makes the method a no-op.
If that is done, afterburner can also be excluded as a dependency.

Does that make sense?

[sapessi]

Thanks @geoand, as soon as the CI checks are done I'll merge in the graalvm branch.

[geoand]

Thanks!

[patriot1burke]

Bump. On Quarkus end, issues are starting to roll in more over this issue.

[snowe2010]

Bump on this again. Any progress yet?

[deki]

I started merging open PRs yesterday. As we were not progressing with the graalvm branch as expected, it's probably best to just merge 3a04d8c for now.
Any objections?

[geoand]

From my outsider's POV, that would be great

[sapessi]

Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

StageName contains invalid characters (Pattern: ^[a-zA-Z0-9-_]+$) at Resources/ServerlessHttpApiApiGatewayDefaultStage/Properties/StageName

[deki]

Ok let's do that. Would you mind to rebase your branch on the dev branch? I'll merge it afterwards...

[geoand]

Do you want me to do that?

Asking because I saw that one of the maintainer of the project pushed commits into the PR's branch

[deki]

@geoand yeah, I think @sapessi pushed the commits from the graalvm branch to it (to combine it). Would be great if you could restore the original version based on the current dev branch. Sorry for the inconvenience.

[geoand]

Not a problem at all.

Done :)

[deki]

Thank you!

[geoand]

You are welcome!