Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTTP API cookie parameter #453

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

arthurkamwt
Copy link
Contributor

Issue #452

Description of changes:

For request v2 (HTTP APIs), read cookies from the dedicated section in addition to headers. HTTP APIs also filter cookies with no names.

Unsure if HTTP API will never send cookie in header; if so, we can remove the header parse section.

Testing:
mvn test

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@deki
Copy link
Collaborator

deki commented Mar 30, 2022

Thank you for your contribution, looks got to me. I think we leave the header parse section in there for now (for backwards compatibility).

@deki deki merged commit 304ce92 into aws:main Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants