-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make compatible with Jakarta namespace #478
Conversation
With reference to issue: #477 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work you put into it.
There are a lot of whitespace changes make it difficult to sort out the real changes but I already saw some places that look like a merge error to me. Would you mind double checking?
I'll probably merge this to a different branch, so another volunteer (or myself) can work on the Multipart stuff. Spring 6 and Spring Boot 3 will be released soon and I will include it along with this change as well.
...-java-container-core/src/main/java/com/amazonaws/serverless/proxy/model/AwsProxyRequest.java
Show resolved
Hide resolved
...-java-container-core/src/main/java/com/amazonaws/serverless/proxy/model/AwsProxyRequest.java
Show resolved
Hide resolved
...va-container-core/src/main/java/com/amazonaws/serverless/proxy/model/SingleValueHeaders.java
Show resolved
Hide resolved
Thank you for pointing this out. Since this branch was based on an earlier commit of the master branch, it didn’t include the most recent change. My last commit to this branch addresses this and resolves the merge conflict. We are using the submitted code in a lambda to host our webserver – so it is working for our purposes as-is, as we don’t need multipart support. |
@deki Is there any timeline in place to get these changes sorted, merged and released? Got a Spring Boot 3 application which I'm planning to move to AWS Lambda, so am wondering if I need to go and tinker it myself, or put it on the back burner until the new release. |
Hi folks, @farazhv while comparing with your PR, I notice a NullInputStream and some changes related to binary reading? Is that needed? Could you please test the main branch if it's working for you? |
@deki sure we will test the main branch as soon as we can |
We released a 2.0.0-M1 version today. Please continue testing and open a new PR with the remaining changes if needed. |
@deki we aren't blocked by this so we won't be able to test it for the time being |
Issue #, if available:
Multipart form upload is not supported
Description of changes:
Compatible with Jakarta namespace
By submitting this pull request