Add ALB Context to API GW Payload V2

[driverpt]

Issue #489

Description of changes:
Adds ALB Context to Request Context. Source

By submitting this pull request

• [ X ] I confirm that my contribution is made under the terms of the Apache 2.0 license.
• [ X ] I confirm that I've made a best effort attempt to update all relevant documentation.

[deki]

Hi @driverpt,
thank you very much for your contribution. While validating the changes, I'm seeing test failures locally. Our GitHub CI action was misconfigured, otherwise it would have reported it here (it's now fixed in main). Can you please rebase on main and push again so make sure those are not related?

[driverpt]

Done

[deki]

The changes currently cause com.amazonaws.serverless.proxy.spark.HelloWorldSparkStreamTest and com.amazonaws.serverless.proxy.spring.ServletAppTest to fail. I can take a closer look next week...

[driverpt]

Hello @deki , i think it should be fixed now. There was a missing @JsonIgnore

[driverpt]

Any ETA on this one ?

[deki]

On my list for this week, first tests were successful.

We may switch to aws-lambda-java-events lib in the future and I'm wondering about this:
https://github.com/aws/aws-lambda-java-libs/blob/events-v4-serialization-v2/aws-lambda-java-events/src/main/java/com/amazonaws/services/lambda/runtime/events/ApplicationLoadBalancerRequestEvent.java

[driverpt]

Alb request is pretty much the same as Payload V2. I also agree this lib should be switched to use Events Library, but that would probably be a breaking change.

[deki]

Yeah that's a 2.0 thing, we will not do it now. I was just thinking that it is probably not enough to have a single event (like in aws-lambda-java-events lib) but we rather need ApplicationLoadBalancerRequestEventV1 and ApplicationLoadBalancerRequestEventV2, don't we?

[driverpt]

@deki , I think that SRP (Single Responsibility Principle) should be applied where possible, as in, 1 Event = 1 Class

[driverpt]

@deki , do you want me to change to separate events and apply SRP ?

[deki]

No let's keep it like this for know and refactor for 2.0.