Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof-of-concept of Spring Boot, Servlet API, and Spring MVC support #65

Merged
merged 1 commit into from
Oct 12, 2017

Conversation

ceefour
Copy link
Contributor

@ceefour ceefour commented Sep 2, 2017

I apologize for so many changes.

This adds support for Spring Boot, Servlet API, and Spring MVC.

  • added new handler for Spring Boot (entire loader lifecycle)
  • changed handling of servlet in the end of filter chain to better mimic Servlet API behavior, instead of after all Filters have finished executing

Proof of concept is https://github.com/ceefour/wicket8serverless , deployed at https://im9ntgimlc.execute-api.us-east-1.amazonaws.com/prod/

Hopefully this can pave way to official support from Spring Cloud Function, see spring-cloud/spring-cloud-function#107

@sapessi
Copy link
Collaborator

sapessi commented Sep 5, 2017

Hey @ceefour , like the changes. Can I ask you to send the pull request to the servlet-improvements branch. We need to add unit tests. I'll merge it there, test it, and then push to master.

@ceefour ceefour closed this Sep 6, 2017
@ceefour ceefour changed the base branch from master to servlet-improvements September 6, 2017 04:27
@ceefour ceefour reopened this Sep 6, 2017
@ceefour
Copy link
Contributor Author

ceefour commented Sep 6, 2017

@sapessi Thanks for the response, I apologize for not having unit tests. I've edited this request to servlet-improvements branch.

@sapessi
Copy link
Collaborator

sapessi commented Sep 6, 2017

Thanks @ceefour - I'll merge and work through the unit tests.

@sapessi
Copy link
Collaborator

sapessi commented Oct 12, 2017

Merging into branch to add unit tests and fixes.

@sapessi sapessi merged commit 97c9350 into aws:servlet-improvements Oct 12, 2017
sapessi added a commit that referenced this pull request Oct 12, 2017
…lt execution. The servlet is injected in the chain by the FilterChainManager. This should fix the last issues with #65 and fix #66
@sapessi sapessi added this to the Release 0.8 milestone Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants