Merge pull request #264 from aws/WithHelperAddition

add support for withHelper for config field
aws · Jan 22, 2021 · 0df1483 · 0df1483
2 parents 9d27659 + e8f79b0
commit 0df1483
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/...n/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/ServiceGenerator.java b/...n/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/ServiceGenerator.java
@@ -145,7 +145,7 @@ private void generateConfig() {
             });
         });
 
-        getAllConfigFields().stream().filter(ConfigField::withHelper)
+        getAllConfigFields().stream().filter(ConfigField::getWithHelper)
                 .forEach(configField -> {
                     writer.writeDocs(
                             String.format("With%s returns a functional option for setting the Client's %s option.",

diff --git a/...y-go-codegen/src/main/java/software/amazon/smithy/go/codegen/integration/ConfigField.java b/...y-go-codegen/src/main/java/software/amazon/smithy/go/codegen/integration/ConfigField.java
@@ -54,7 +54,7 @@ public Symbol getType() {
     /**
      * @return Returns if the config option should have a with helper or not.
      */
-    public Boolean withHelper() {
+    public Boolean getWithHelper() {
         return withHelper;
     }
 
@@ -67,7 +67,7 @@ public Optional<String> getDocumentation() {
 
     @Override
     public SmithyBuilder<ConfigField> toBuilder() {
-        return builder().type(type).name(name).documentation(documentation);
+        return builder().type(type).name(name).documentation(documentation).withHelper(withHelper);
     }
 
     public static Builder builder() {
@@ -85,12 +85,13 @@ public boolean equals(Object o) {
         ConfigField that = (ConfigField) o;
         return Objects.equals(getName(), that.getName())
                 && Objects.equals(getType(), that.getType())
-                && Objects.equals(getDocumentation(), that.getDocumentation());
+                && Objects.equals(getDocumentation(), that.getDocumentation())
+                && Objects.equals(getWithHelper(), that.getWithHelper());
     }
 
     @Override
     public int hashCode() {
-        return Objects.hash(getName(), getType(), getDocumentation());
+        return Objects.hash(getName(), getType(), getDocumentation(), getWithHelper());
     }
 
     /**