Add Go Synthetic Trait equality methods #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srchase
approved these changes
Apr 11, 2023
syall
force-pushed
the
go-synthetic-equality
branch
from
90fd9c9 to
4516575
Compare
sugmanue
reviewed
Apr 11, 2023
codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/Synthetic.java
Outdated
Show resolved
Hide resolved
codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/Synthetic.java
Outdated
Show resolved
Hide resolved
syall
force-pushed
the
go-synthetic-equality
branch
from
4516575 to
0efd642
Compare
When using smithy diff or trait comparisons for the Go `Synthetic` trait, the following exception is thrown in the `createNode()` implementation: ```text "attempted to serialize runtime only trait" ``` This is due to inheriting from `AbstractTrait`'s equality methods which use the `ToNode()` method which calls the `createNode()` method. This change adds an `equals()` and `hashCode()` implementation for the Go `Synthetic` trait that does not use `ToNode()` or `createNode()`. `ToNode()` cannot be overriden since `AbstractTrait`'s implementation is marked as `final`.
syall
force-pushed
the
go-synthetic-equality
branch
from
0efd642 to
1077edc
Compare
sugmanue
approved these changes
Apr 12, 2023
isaiahvita
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A.
Description of changes:
When using smithy diff or trait comparisons for the Go
Synthetictrait, the following exception is thrown in the
createNode()implementation:
This is due to inheriting from
AbstractTrait's equality methods whichuse the
ToNode()method which calls thecreateNode()method.This change adds an
equals()andhashCode()implementation for theGo
Synthetictrait that does not useToNode()orcreateNode().ToNode()cannot be overriden sinceAbstractTrait's implementation ismarked as
final.Testing:
make smithy-clean smithy-build smithy-publish-local smithy-cleansucceeded.make generatein aws/aws-sdk-go-v2 produced no diffs.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.