Adding kpl metric to track the time for oldest future in processing #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yatins47
changed the title
ashwing
reviewed
Dec 1, 2020
| @@ -18,6 +18,8 @@ | |||
|
|
|||
| int getOutstandingRecordsCount(); | |||
|
|
|||
| long getOldestRecordTimeInSeconds(); | |||
There was a problem hiding this comment.
We discussed that this should be default right?
There was a problem hiding this comment.
Added. Will need to update the java version to be 1.8 as well from 1.7 currently
...-kinesis-producer/src/main/java/com/amazonaws/services/kinesis/producer/KinesisProducer.java
Outdated
Show resolved
Hide resolved
...-kinesis-producer/src/main/java/com/amazonaws/services/kinesis/producer/KinesisProducer.java
Outdated
Show resolved
Hide resolved
...-kinesis-producer/src/main/java/com/amazonaws/services/kinesis/producer/KinesisProducer.java
Outdated
Show resolved
Hide resolved
...-kinesis-producer/src/main/java/com/amazonaws/services/kinesis/producer/KinesisProducer.java
Outdated
Show resolved
Hide resolved
...-kinesis-producer/src/main/java/com/amazonaws/services/kinesis/producer/KinesisProducer.java
Outdated
Show resolved
Hide resolved
ashwing
changed the title
ashwing
approved these changes
Dec 14, 2020
| @@ -200,6 +203,10 @@ public long getAggregationMaxSize() { | |||
| return aggregationMaxSize; | |||
| } | |||
|
|
|||
| public long getFutureTimeoutInSeconds() { | |||
There was a problem hiding this comment.
Few customers are sensitive to even 500ms. Can we change this to ms?
| @@ -147,6 +151,7 @@ public void run() { | |||
| log.info(String.format( | |||
| "Put %d of %d so far (%.2f %%), %d have completed (%.2f %%)", | |||
| put, total, putPercent, done, donePercent)); | |||
| log.info("Oldest future as of now is " + producer.getOldestRecordTimeInSeconds()); | |||
There was a problem hiding this comment.
nit : oldest Record. You can fix in next round
|
Merging in changes after Ashwin's approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Adding metrics for future time.
Old PR Link : #319
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.