Log number of failed records and update logging documentation #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log number of failed records and update logging documentation
…s planned to be deprecated. Signed-off-by: forestmvey <[email protected]>
|
Changes have been reviewed downstream, therefore I am merging the PR. |
forestmvey
added a commit
to forestmvey/amazon-timestream-connector-prometheus
that referenced
this pull request
May 7, 2024
…s#56) * Log failed number of written records * Fix typo in NewMissingHeaderError * Document logged errors and add new errors * Removing note for all errors are being logged as this functionality is planned to be deprecated. Signed-off-by: forestmvey <[email protected]> --------- Signed-off-by: forestmvey <[email protected]> Co-authored-by: Trevor Bonas <[email protected]>
forestmvey
added a commit
to forestmvey/amazon-timestream-connector-prometheus
that referenced
this pull request
May 7, 2024
…s#56) * Log failed number of written records * Fix typo in NewMissingHeaderError * Document logged errors and add new errors * Removing note for all errors are being logged as this functionality is planned to be deprecated. Signed-off-by: forestmvey <[email protected]> --------- Signed-off-by: forestmvey <[email protected]> Co-authored-by: Trevor Bonas <[email protected]>
forestmvey
added a commit
to forestmvey/amazon-timestream-connector-prometheus
that referenced
this pull request
May 7, 2024
…s#56) * Log failed number of written records * Fix typo in NewMissingHeaderError * Document logged errors and add new errors * Removing note for all errors are being logged as this functionality is planned to be deprecated. Signed-off-by: forestmvey <[email protected]> --------- Signed-off-by: forestmvey <[email protected]> Co-authored-by: Trevor Bonas <[email protected]>
forestmvey
added a commit
to forestmvey/amazon-timestream-connector-prometheus
that referenced
this pull request
May 7, 2024
…s#56) * Log failed number of written records * Fix typo in NewMissingHeaderError * Document logged errors and add new errors * Removing note for all errors are being logged as this functionality is planned to be deprecated. Signed-off-by: forestmvey <[email protected]> --------- Signed-off-by: forestmvey <[email protected]> Co-authored-by: Trevor Bonas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
README.mdthat all mentioned errors in that section will be logged.ParseRetriesErrorhas been added toREADME.md.UnknownMatcherErrorhas been added toREADME.md.NewMissingHeaderError.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.