Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Empty Env varibales for STSWebIdentity #246

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Jul 31, 2024

The pointer is a dangling pointer after we have destroyed it which can lead to accessing garbage memory or double free errors.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@waahm7 waahm7 marked this pull request as ready for review July 31, 2024 20:52
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.44%. Comparing base (300ae82) to head (7789cae).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
+ Coverage   80.38%   80.44%   +0.05%     
==========================================
  Files          33       33              
  Lines        6037     6038       +1     
==========================================
+ Hits         4853     4857       +4     
+ Misses       1184     1181       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waahm7 waahm7 merged commit d789525 into main Jul 31, 2024
30 checks passed
@waahm7 waahm7 deleted the fix-sts-web-identitiy-empty branch July 31, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants