Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add content-sha256 header for presign when the signed_body_value is set to UNSIGNED-PAYLOAD #248

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

TingDaoK
Copy link
Contributor

Issue #, if available:

  • When signing via query-params, there is no available way to sign content-sha256 header

Description of changes:

  • When the signed_body_value is set to UNSIGNED-PAYLOAD, signer will add the content-sha256 header even signing via query-params.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.40%. Comparing base (877c029) to head (bb68463).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   80.39%   80.40%           
=======================================
  Files          33       33           
  Lines        6035     6038    +3     
=======================================
+ Hits         4852     4855    +3     
  Misses       1183     1183           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TingDaoK TingDaoK changed the title add content-sha256 header for presign add content-sha256 header for presign when the signed_body_value is set to UNSIGNED-PAYLOAD Sep 3, 2024
@TingDaoK TingDaoK merged commit 1de5445 into main Sep 3, 2024
30 checks passed
@TingDaoK TingDaoK deleted the presign-content-sha256 branch September 3, 2024 20:32
TingDaoK added a commit that referenced this pull request Sep 4, 2024
…lue is set to UNSIGNED-PAYLOAD (#248)"

This reverts commit 1de5445.
@TingDaoK TingDaoK mentioned this pull request Sep 4, 2024
graebm pushed a commit that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants