Request response streaming #860
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfod
reviewed
Jan 15, 2025
| mqttRequestResponseClientSubmitRequest(getNativeHandle(), request, future); | ||
| this.handleReadLock.lock(); | ||
| try { | ||
| mqttRequestResponseClientSubmitRequest(getNativeHandle(), request, future); |
There was a problem hiding this comment.
With new locks, it's still possible that getNativeHandle() returns 0 here. Java_software_amazon_awssdk_crt_iot_MqttRequestResponseClient_mqttRequestResponseClientSubmitRequest should check for NULL, but currently it doesn't.
| * native -> Java in the same call stack. This is true for both the request response client and streaming | ||
| * operations, allowing us to add this layer of safety. | ||
| */ | ||
| private final ReentrantReadWriteLock handleLock = new ReentrantReadWriteLock(); |
There was a problem hiding this comment.
Why reentrant lock? Creating new operations and closing the client can't call each unless I missed something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.