-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix webpack build error #220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a pretty substantial PR (and we definitely appreciate the work put into it) and outside my expertise. Do you have any additional suggestions for evaluating/testing/understanding the work you've done here?
We might need to rebase since this PR has been open for almost a year now, but IMO the unit tests that haven't run yet should satisfy any testing requirements. This still actively happens with
|
Issue #, if available:
Description of changes:
The reason for this PR is during my electron build, webpack says the AWS CRT module is not found.
aws/aws-iot-device-sdk-js-v2#158
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.