Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MD5 to operate over data #221

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Fix MD5 to operate over data #221

merged 5 commits into from
Jan 10, 2024

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Jan 9, 2024 •
edited
Loading

Description of changes:

  • Change MD5 function to operate over data instead of String to avoid any encoding/decoding issues and just operate on arbitrary bytes.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dayaffe dayaffe self-requested a review January 9, 2024 21:24
@dayaffe dayaffe self-requested a review January 9, 2024 21:32
@dayaffe dayaffe linked an issue Jan 9, 2024 that may be closed by this pull request
Move MD5 hashing to a Data extension and return Data type directly + rename all checksum functions with compute prefix #222
Closed
2 tasks
@waahm7 waahm7 merged commit 1367dc5 into main Jan 10, 2024
9 checks passed
@waahm7 waahm7 deleted the fix-md5 branch January 10, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dayaffe dayaffe dayaffe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@waahm7 @dayaffe