Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kms_encryption_key_arn and cache_control parameters for s3 deploy #669

Merged
merged 1 commit into from
Mar 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/providers-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -647,3 +647,11 @@ Provider type: `s3`.
- *role* - *(String)* default:
`arn:${partition}:iam::${target_account_id}:role/adf-cloudformation-role`.
- The role you would like to use for this action.
- *kms_encryption_key_arn* - *(String)*
- The ARN of the AWS KMS encryption key for the host bucket. The
`kms_encryption_key_arn` parameter encrypts uploaded artifacts with the
provided AWS KMS key. For a KMS key, you can use the key ID, the key ARN,
or the alias ARN.
- *cache_control* - *(String)*
- The `cache_control` parameter controls caching behavior for
requests/responses for objects in the bucket.
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,28 @@ def _generate_configuration(self):
.get('object_key')
))
),
"KMSEncryptionKeyARN": (
faridnsh marked this conversation as resolved.
Show resolved Hide resolved
self.target
.get('properties', {})
.get('kms_encryption_key_arn', (
self.map_params
.get('default_providers', {})
.get('deploy', {})
.get('properties', {})
.get('kms_encryption_key_arn')
))
),
"CacheControl": (
self.target
.get('properties', {})
.get('cache_control', (
self.map_params
.get('default_providers', {})
.get('deploy', {})
.get('properties', {})
.get('cache_control')
))
),
}
if self.provider == "CodeStarSourceConnection":
default_source_props = (
Expand Down