Remove LogGroup Name as a Dimension

awslabs · Mar 31, 2021 · 76a62a6 · 76a62a6
1 parent 6065d2e
commit 76a62a6
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 5 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "aws-embedded-metrics",
-  "version": "2.0.4",
+  "version": "3.0.0",
   "description": "AWS Embedded Metrics Client Library",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",

diff --git a/src/logger/MetricsLogger.ts b/src/logger/MetricsLogger.ts
@@ -140,9 +140,6 @@ export class MetricsLogger {
 
   private configureContextForEnvironment = (context: MetricsContext, environment: IEnvironment): void => {
     const defaultDimensions = {
-      // LogGroup name will entirely depend on the environment since there
-      // are some cases where the LogGroup cannot be configured (e.g. Lambda)
-      LogGroup: environment.getLogGroupName(),
       ServiceName: Configuration.serviceName || environment.getName(),
       ServiceType: Configuration.serviceType || environment.getType(),
     };

diff --git a/test/integ/agent/end-to-end.integ.ts b/test/integ/agent/end-to-end.integ.ts
@@ -81,7 +81,6 @@ const metricExists = async (metricName: string, expectedSampleCount: number): Pr
     Dimensions: [
       { Name: 'ServiceName', Value: serviceName },
       { Name: 'ServiceType', Value: serviceType },
-      { Name: 'LogGroup', Value: logGroupName },
       { Name: dimensionKey, Value: dimensionValue },
     ],
     Period: 60,