fix: refactor smoke test tests to use already running gradle instance #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0marperez
added
the
no-changelog
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
|
|
A new generated diff is ready to view.
|
Affected ArtifactsNo artifacts changed size |
lauzadis
reviewed
Feb 28, 2025
| "-Paws.kotlin.native=false", // FIXME: Remove `-Paws.kotlin.native=false` when Kotlin Native is ready | ||
| val processBuilder = | ||
| ProcessBuilder( | ||
| if (System.getProperty("os.name").contains("Windows", ignoreCase = true)) ".\\gradlew.bat" else "./gradlew", |
There was a problem hiding this comment.
You should re-use PlatformProvider.System which already offers utilities for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
N/A
Description of changes
Uses a
ProcessBuilderinstead of aGradleRunnerto run the tests. Assures already running Gradle instance is used instead of starting up a new one.This should lower memory usage of the tests and brings test run times from ~3 min to ~30 sec
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.