Add more format handling to rfc3164, and passthrough output #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts, and add passthrough decoder
crisidev
reviewed
Mar 31, 2020
kurojishi
reviewed
Mar 31, 2020
| @@ -63,6 +52,74 @@ struct Pri { | |||
| severity: Option<u8>, | |||
| } | |||
|
|
|||
| fn decode_rfc_standard(pri: &Pri, msg: &str, line: &str) -> Result<Record, &'static str> { | |||
| // Decoding "usual" rfc input as advised in the rfc: [<pri>]<datetime> <hostname> <message> | |||
There was a problem hiding this comment.
Usual is a bit of a weighed word here, recommended is probably better
There was a problem hiding this comment.
fair enough. will update the comment
| } | ||
|
|
||
| fn decode_rfc_custom(pri: &Pri, msg: &str, line: &str) -> Result<Record, &'static str> { | ||
| // Decoding custom rfc input formatted as : [<pri>]<hostname>: <datetime>: <message> |
There was a problem hiding this comment.
what happned when we find a slightly different one again? Or is this the only real offender in the wild?
There was a problem hiding this comment.
This is one of device custom log formats, in this case for cisco devices, dates and hostnames makes flowgger compliant with nxos and ios. Most devices seem to comply with the recommanded usage. However there is for sure other formats. I cannot add all existing formats here, but the design update makes it easier to add them on case by case.
kurojishi
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC3164 is very wide, and many (if not an) log format are allowed.
This pull requests improves the format accepted:
A passthrough output module has also been added. When using RFC3164 for instance, it allows pushing events received in different format while conserving them, rather than reformating them in a common format.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.