Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple SD in RFC5424 (fix issue #61) #62

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Conversation

vche
Copy link
Contributor

@vche vche commented Nov 23, 2021

*Issue #61 *

Description of changes:

  • The log record structure has been updated to have structured data (SD) field as a vector instead of a single instance, in order to be able to hold multiple structured data
  • Every decoder has been updated to store a vector with the processed SD (but only RFC5424 logs can have more than 1)
  • RFC5424 decoder has been updated to parse every SD, in case multiple are specified, instead of only the first one
  • Every encoder has beem updated to output every SD entry, whenever possible (capnp records can only hold 1, gelf and lstsv have limitation when the same key is specified in mutiple SD).
  • Unit tests added for every encoder/decoder to validate the multiple SD handling
  • Small typos and cosmetic changes
  • Version update

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@kurojishi kurojishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vche vche merged commit a1d4738 into master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants