Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(construct): SageMaker JumpStart construct endpoint name update #300

Merged
merged 2 commits into from
Mar 5, 2024
Merged

chore(construct): SageMaker JumpStart construct endpoint name update #300

merged 2 commits into from
Mar 5, 2024

Conversation

krokoko
Copy link
Collaborator

@krokoko krokoko commented Mar 5, 2024

Fixes #

  • prepend 'jumpstart-' to the endpoint name deployed by the construct
  • make the property endpoint name required
  • update tests and documentation
  • tested with the samples through a local build of the constructs, will update the associated sample once this is merged

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@krokoko krokoko requested a review from a team as a code owner March 5, 2024 02:34
@codecov Codecov
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.68%. Comparing base (5dd3d9a) to head (e5167cd).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files          37       37           
  Lines        9277     9277           
  Branches      279      279           
=======================================
  Hits         8877     8877           
  Misses        400      400

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

justintlewis
justintlewis approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@justintlewis justintlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@krokoko krokoko enabled auto-merge (squash) March 5, 2024 02:56
@krokoko krokoko merged commit e9220f4 into awslabs:main Mar 5, 2024
22 checks passed
@krokoko krokoko deleted the jumpstart_name branch March 11, 2024 19:01
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justintlewis justintlewis justintlewis approved these changes

@dineshSajwan dineshSajwan dineshSajwan approved these changes

@hvital hvital Awaiting requested review from hvital hvital is a code owner automatically assigned from awslabs/generative-ai-cdk-constructs-maintainers

@laithalsaadoon laithalsaadoon Awaiting requested review from laithalsaadoon laithalsaadoon is a code owner automatically assigned from awslabs/generative-ai-cdk-constructs-maintainers

@MichaelWalker-git MichaelWalker-git Awaiting requested review from MichaelWalker-git MichaelWalker-git is a code owner automatically assigned from awslabs/generative-ai-cdk-constructs-maintainers

Assignees
No one assigned
Labels
distinguished-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krokoko @justintlewis @dineshSajwan @emerging-tech-cdk-constructs-bot