Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cw): update bedrock cloudwatch dashboard #829

Merged
merged 5 commits into from
Nov 29, 2024
Merged

Conversation

krokoko
Copy link
Collaborator

@krokoko krokoko commented Nov 29, 2024

Fixes #

Thanks @jimini55 for the pricing widget !

Update the bedrock CloudWatch dashboard to add the following:

  • Missing runtime metrics added recently
  • Add default = {} to props to avoid providing empty brackets if props not provided by user
  • Create a CfnOutput with as value the URL of the created cloudwatch dashboard
  • Pricing widget for a model if input/output pricing is provided by the user
  • Update documentation

Tests:

Screenshot 2024-11-29 at 11 23 56 AM image

Also tested to generate 2 dashboards in the same stack to make sure there is no collision in naming/id


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@krokoko krokoko enabled auto-merge (squash) November 29, 2024 20:18
Copy link
Contributor

@MichaelWalker-git MichaelWalker-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krokoko krokoko merged commit 70a67db into awslabs:main Nov 29, 2024
15 checks passed
@krokoko krokoko deleted the cw_dash branch February 10, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants