-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(config): remove deprecated field #658
Open
richardkeit
wants to merge
18
commits into
awslabs:main
Choose a base branch
from
richardkeit:fix/uninstall
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richardkeit
commented
Nov 25, 2024
•
edited
Loading
edited
- Running the installer process, this field is no longer required
- Silent error (without debug option) is hard to diagnose (given default behaviour in Cloudformation template from the workshop doesn't expose the entry point)
Currently the default DNS naming convention for Route 53 hosted zones of VPC endpoints is using sagemaker.api.{region}.amazonaws.com which is not the correct DNS for it as can be found in Endpoints & Quotas page https://docs.aws.amazon.com/general/latest/gr/sagemaker.html This is also the case for sagemaker runtime as well.
…le dashes for vpc lookups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.