Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CredentialProviderChain instantiation during initialize #118

Merged
merged 1 commit into from
Apr 12, 2019

Conversation

SharpEdgeMarshall
Copy link
Contributor

@SharpEdgeMarshall SharpEdgeMarshall commented Dec 22, 2018

Closes #117

Not a ruby expert here,
Digging inside the code trying to solve #117 I saw that a new CredentialProviderChain is created for each request.
This could be "fine" if you use ENV vars or credentials file but in our case, we are using STS and this is causing a big number of request to the metadata service.

So the solution is to move the CredentialProviderChain instantiation during the initialize of the ManticoreAdapter Class

@SharpEdgeMarshall
Copy link
Contributor Author

No feedback?

@crisidev
Copy link

crisidev commented Apr 10, 2019

We will be working on this soon. Sorry for the delay :(

Thanks a million for your contribution!

@crisidev
Copy link

This LGTM. ETA for get this fully released is beginning of next week.

@SharpEdgeMarshall
Copy link
Contributor Author

@crisidev We are using a fork of the 6.4.1 with this PR for at least 4 months and I can confirm it works flawlessly.

@crisidev
Copy link

Ok, good to know!

We have our internal testing and release process which will help us to scope possible bugs and issues, but it is really nice to see you already have it running.

Thanks for the help! I'll keep you posted.

@salamanderrex
Copy link
Contributor

LGTM. I will merge the code and release as 6.4.2.

@salamanderrex salamanderrex merged commit 2cc09d7 into awslabs:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6.4.x causing continuous calls to AWS Metadata
3 participants