Move CredentialProviderChain instantiation during initialize #118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #117
Not a ruby expert here,
Digging inside the code trying to solve #117 I saw that a new
CredentialProviderChain
is created for each request.This could be "fine" if you use ENV vars or credentials file but in our case, we are using STS and this is causing a big number of request to the metadata service.
So the solution is to move the
CredentialProviderChain
instantiation during the initialize of theManticoreAdapter
Class