Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add async support #50

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Conversation

scottgerring
Copy link
Contributor

Issue #, if available:
#17

Description of changes:
I've taken @richardsmithsfdc 's branch and merged the intermediate changes from master down into it. We'd love to be able to use the CRT with AWS Powertools for Lambda (Java), and we use this library for our SQS large message offloading.

This PR so far is just a mechanical resolution of the diff between Richard's branch and master to try and get us closer to the point we can merge this in and release. I've not gone through Richard's changes in depth yet - I expect we'll want a full review of all of this.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@ziyanli-amazon ziyanli-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ziyanli-amazon ziyanli-amazon merged commit 208f10c into awslabs:master Mar 5, 2024
@scottgerring scottgerring deleted the AsyncSupport branch March 6, 2024 07:06
@richardsmithsfdc
Copy link
Contributor

richardsmithsfdc commented Mar 6, 2024

@ziyanli-amazon and @scottgerring , thank you!

For reference, I updated my draft PR of async payload offloading support in AWS SQS extended client library , in case anyone wants to do anything with that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants