Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwrap testimonials in storybook and fix alphabetical sorting #1898

Closed
raphael-suter opened this issue Jul 24, 2020 · 2 comments · Fixed by #1985
Closed

Unwrap testimonials in storybook and fix alphabetical sorting #1898

raphael-suter opened this issue Jul 24, 2020 · 2 comments · Fixed by #1985
Assignees
Labels
Accepted A feature request or issue is accepted and will be implemented Enhancement Internal Wishes that only affect the development team.

Comments

@raphael-suter
Copy link
Contributor

The story for testimonials should be top level like all other component stories.

Screenshot 2020-07-24 at 11 26 58

Couldn't do it because of a strange storybook behaviour: when unwrapped, storybook moves the entire components section into a folder below 'OTHERS'

Screenshot 2020-07-24 at 11 37 43

We should try again as soon as we have updated our storybook to 6.0.0 (#1774).

@raphael-suter
Copy link
Contributor Author

Storybook doesn't want us to have top level stories. I assume it only works due to a bug in the storiesOf Api that we are using to create our stories and that's why we have this weird side effect.

I guess the update wont help.

Also have a look at #1900

@danyball
Copy link
Contributor

new Story format CSF always group by title. But we want to have a flat list. (Is also related to the alphabetical sorting.) --> storybookjs/storybook#8255

@raphaellueckl raphaellueckl added the Accepted A feature request or issue is accepted and will be implemented label Sep 3, 2020
@01231 01231 changed the title Unwrap testimonials in storybook Unwrap testimonials in storybook and fix alphabetical sorting Sep 10, 2020
@raphael-suter raphael-suter self-assigned this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted A feature request or issue is accepted and will be implemented Enhancement Internal Wishes that only affect the development team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants