Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/1898_fix-story-sorting #1985

Merged
merged 4 commits into from
Oct 6, 2020
Merged

feature/1898_fix-story-sorting #1985

merged 4 commits into from
Oct 6, 2020

Conversation

raphael-suter
Copy link
Contributor

@raphael-suter raphael-suter commented Oct 5, 2020 •
edited
Loading

Fixes #1898

Merge Checklist:

  • Code selfreview has been performed (Best Practices).
  • Tests are sufficient.
  • Modifications still work in IE.
  • Documentation is up to date.
  • Changelog is up to date.
  • Typescript typings for properties are up to date.
  • Designers approved changes or no approval needed.

@raphael-suter raphael-suter self-assigned this Oct 5, 2020
@raphael-suter raphael-suter added the R4R Ready for Review - Please review this PR. label Oct 5, 2020
danyball
danyball approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@danyball danyball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And still just one click, nice

01231
01231 approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@01231 01231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@01231
Copy link
Contributor

01231 commented Oct 6, 2020

I can see the 55 merge conflicts to my PR😫

@raphael-suter raphael-suter merged commit 0654bbc into develop Oct 6, 2020
@raphael-suter raphael-suter deleted the feature/1898_fix-story-sorting branch October 6, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyball danyball danyball approved these changes

@01231 01231 01231 approved these changes

@raphaellueckl raphaellueckl Awaiting requested review from raphaellueckl

Assignees

@raphael-suter raphael-suter

Labels
R4R Ready for Review - Please review this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unwrap testimonials in storybook and fix alphabetical sorting
3 participants
@raphael-suter @01231 @danyball