-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/component flat list #1844
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I don't like that all the "main stories" are now called "Story" instead of by their specific component name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
I dont like |
It's called storybook. If we can expect from the user to now what a storybook is we can expect from him that he will understand what a story is. And if he doesn't now what a story is, he'll probably know it as soon as he clicks on the component, because this is the first thing that opens. And due the fact that story will be used throughout the whole storybook this will not be much of a challenge for him. If you really don't like the name story I'll need a better suggestion, because the old naming was not good and redundant. What i don't like about "examples" or "showcase" is, that this would also work for all the demos in my opinion. I know we could also say that about the name "story". What about "Nativ component" or "native story"? This would descriptive and unambiguously. |
I personally prefer story for the reaosons Noah explained |
Fixes #1777
Done is when (DoD):