Feature/upgrade to sb6 #1926
Merged
Feature/upgrade to sb6 #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…r that" This reverts commit fd0f582
danyball
force-pushed
the
feature/upgrade_to_sb6
branch
from
4b90161 to
95051b6
Compare
|
TODO: make IE11 work great again:) |
danyball
requested review from
raphaellueckl,
01231,
markus-walther and
raphael-suter
| @@ -67,7 +67,7 @@ test('should responsive stretch', async t => { | |||
| ]; | |||
| }); | |||
|
|
|||
| const expected = JSON.stringify(['529px', '0px']); // 529px width of the radio correspond to 100% in a 575px window | |||
| const expected = JSON.stringify(['545px', '0px']); // 545px width of the radio correspond to 100% in a 575px window | |||
There was a problem hiding this comment.
The last number was forgotten, maybe just replace this comment with 100% width or something.
There was a problem hiding this comment.
You mean 575px? Thats correct. At this test the browser is resized to 575px width.
raphaellueckl
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1774
fixes #1877
fixes #1900
Info: Many files have changed because i switched the "old" story.js format to the new one "CSF". You do not have to review ALL the story/demo files. But please have a look at all other changes.
unable to fix:
wait to be fixed by others (#1935):
HTMLTab label: 2 Feature Requests whitespace-se/storybook-addon-html#27srcfolder to our project. But than it is a "custom addon" and this causes another error (details below).Done is when (DoD):