Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GIT PULL] workflows/build.yml: install default ubuntu-24.04 clang #1343

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cmazakas
Copy link
Contributor

@cmazakas cmazakas commented Feb 7, 2025

Tooling like bindgen seems to encounter difficulties when using clang that isn't installed via apt. Using the default packaged clang from the Ubuntu apt repos simplifies the workflow and provides the build environment with a relatively modern version of clang (clang-18).

clang-18 should be more than sufficient to test building the library.


git request-pull output:

The following changes since commit 08468cc3830185c75f9e7edefd88aa01e5c2f8ab:

  Merge branch 'Pr1' of https://github.com/romange/liburing (2025-02-03 05:42:36 -0700)

are available in the Git repository at:

  https://github.com/cmazakas/liburing.git gha-clang

for you to fetch changes up to 019c04dad97e5d3b78eec9786e89e17b021d7fd0:

  workflows/build.yml: install default ubuntu-24.04 clang (2025-02-07 07:26:32 -0800)

----------------------------------------------------------------
Christian Mazakas (1):
      workflows/build.yml: install default ubuntu-24.04 clang

 .github/workflows/build.yml | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

By submitting this pull request, I acknowledge that:

  1. I have followed the above pull request guidelines.
  2. I have the rights to submit this work under the same license.
  3. I agree to a Developer Certificate of Origin (see https://developercertificate.org for more information).

sudo apt-get install -y ${{matrix.cc_pkg}} ${{matrix.cxx_pkg}}; \
fi;
sudo apt-get update -y; \
sudo apt-get install -y ${{matrix.cc_pkg}} ${{matrix.cxx_pkg}}; \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not use \ at end of the cmd.

Tooling like bindgen seems to encounter difficulties when using clang
that isn't installed via apt. Using the default packaged clang from the
Ubuntu apt repos simplifies the workflow and provides the build
environment with a relatively modern version of clang (clang-18).

Signed-off-by: Christian Mazakas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants