Using vite plugin node for svelte kit #43
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I want to make this PR so that it is possible to use this plugin for @svelte/kit.
This pr in current form will create breakage to #25, but I would still like to introduce it so that it will play nicely with sveltekit.
Currently there is extensive discussion that the node adapter for the svelte kit is limited especially during the development.
Essentially, I want to pass next parameter to adapter function for the following usage:
The reason why it is necessary is that the sveltekit also mess with middleware. So that it remove the assumption that the vite-plugin-node is the end of all middleware.
I do hope you can consider this change as it greatly helps a lot of the discussion of sveltekit. For example sveltejs/kit#4654