[chore] add conversion SafePrimitive to QuantumCell::Existing (#169)

chore: add conversion `SafePrimitive` to `QuantumCell::Existing`
axiom-crypto · Sep 26, 2023 · 7acbe4d · 7acbe4d
1 parent e36c45b
commit 7acbe4d
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 10 deletions.
diff --git a/halo2-base/src/safe_types/mod.rs b/halo2-base/src/safe_types/mod.rs
@@ -1,5 +1,5 @@
 use std::{
-    borrow::{Borrow, BorrowMut},
+    borrow::Borrow,
     cmp::{max, min},
 };
 

diff --git a/halo2-base/src/safe_types/primitives.rs b/halo2-base/src/safe_types/primitives.rs
@@ -1,3 +1,7 @@
+use std::ops::Deref;
+
+use crate::QuantumCell;
+
 use super::*;
 /// SafeType for bool (1 bit).
 ///
@@ -23,21 +27,17 @@ macro_rules! safe_primitive_impls {
             }
         }
 
-        impl<F: ScalarField> AsMut<AssignedValue<F>> for $SafePrimitive {
-            fn as_mut(&mut self) -> &mut AssignedValue<F> {
-                &mut self.0
-            }
-        }
-
         impl<F: ScalarField> Borrow<AssignedValue<F>> for $SafePrimitive {
             fn borrow(&self) -> &AssignedValue<F> {
                 &self.0
             }
         }
 
-        impl<F: ScalarField> BorrowMut<AssignedValue<F>> for $SafePrimitive {
-            fn borrow_mut(&mut self) -> &mut AssignedValue<F> {
-                &mut self.0
+        impl<F: ScalarField> Deref for $SafePrimitive {
+            type Target = AssignedValue<F>;
+
+            fn deref(&self) -> &Self::Target {
+                &self.0
             }
         }
 
@@ -46,6 +46,12 @@ macro_rules! safe_primitive_impls {
                 safe_primitive.0
             }
         }
+
+        impl<F: ScalarField> From<$SafePrimitive> for QuantumCell<F> {
+            fn from(safe_primitive: $SafePrimitive) -> Self {
+                QuantumCell::Existing(safe_primitive.0)
+            }
+        }
     };
 }