OSX Sandbox - Network issues

[IcemarkUK]

My OSX build is setup with code signing and entitlements, as discussed here.

Sandbox is now working.

The entitlement file looks like it's being picked up.

And the entitlement file has com.apple.security.network.client set to true.

https://github.com/ChilliHugger/The-Lords-Of-Midnight/blob/393d8c6c315e67096d78209794e3b673dd384307/main/midnight/proj.ios_mac/mac/midnight.entitlements#L1-L10

In my cocos build I can access a URL and download from it.

    auto request = new HttpRequest();
    request->setRequestType(HttpRequest::Type::GET);
    request->setUrl("https://thelordsofmidnight.com/version/lom_v2.0_osx.cfg");
    request->setResponseCallback([&,callback](HttpClient* client, HttpResponse* response)
    {
        try
        {
            if(response->isSucceed())
            {
// ... do stuff
            }
        } catch (const std::exception& e) {
        }
    });

    HttpClient::getInstance()->send(request);
    request->release();

In my axmol build the response fails and I see this in the logs...

  [yasio][1707678408336][index: 0] start query thelordsofmidnight.com...
  [yasio][1707678408336][index: 0] connecting server thelordsofmidnight.com(188.64.190.46):443...
  [yasio][1707678408337][index: 0] connect server thelordsofmidnight.com(188.64.190.46):443 failed, ec=1, detail:Operation not permitted

If I remove the entitlement file and disable code signing and set to run locally - it works fine.

[halx99]

The error reported by os, check does follow link helpful?
flutter/flutter#47606

[IcemarkUK]

I'll go hunting for the OS error...

But the link above doesn't help as I already have the network client entitlement set, and it doesn't suggest anything else.

[rh101]

Is there any chance this is not entirely network related, but that something is attempting to read or write from a location that can't be accessed without specific entitlements being enabled?

[rh101]

Better fix seems to be just calling the 3 parameter version of initWithFullScreen from the other overload, since it's practically the same code. It compiles fine on Windows, but just doesn't want to compile on MacOS:

I could only get it to compile by explicitly implementing it all:

bool GLViewImpl::initWithFullScreen(std::string_view viewName)
{
    // Create fullscreen window on primary monitor at its current video mode.
    _monitor = glfwGetPrimaryMonitor();
    if (nullptr == _monitor)
        return false;

    const GLFWvidmode* videoMode = glfwGetVideoMode(_monitor);

    // These are soft constraints. If the video mode is retrieved at runtime, the resulting window and context should
    // match these exactly. If invalid attribs are passed (eg. from an outdated cache), window creation will NOT fail
    // but the actual window/context may differ.
    glfwWindowHint(GLFW_REFRESH_RATE, videoMode->refreshRate);
    glfwWindowHint(GLFW_RED_BITS, videoMode->redBits);
    glfwWindowHint(GLFW_BLUE_BITS, videoMode->blueBits);
    glfwWindowHint(GLFW_GREEN_BITS, videoMode->greenBits);

    return initWithRect(viewName, ax::Rect(0, 0, (float)videoMode->width, (float)videoMode->height), 1.0f, false);
}

That fixes the issue, so it sets the correct monitor frequency.

[rh101]

@halx99 Do you want me to submit a PR for the refresh rate issue?

[halx99]

sure, why not

[IcemarkUK]

I don't think so no. You need sandbox for uploading to the AppStore and Hardened Runtime for Notorization.

[IcemarkUK]

I only set the 14.2 because I was testing on my laptop and I was getting bugged that it kept not selecting the MacOS SDK which on that machine was 14.2 - setting the option there seemed to work fine.

[halx99]

build success, but when I run it:

NOTE: I also enable -DTESTS=YES

OK, I reproduce it when remove -DTESTS=YES

[halx99]

track issue: simdsoft/yasio#441

[halx99]

Fixed by c7669aa

[IcemarkUK]

The -DTESTS option just builds a version that runs unit tests - which I haven't built during this migration.

[IcemarkUK]

Many many thanks!!