-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android update NDK to latest version ndk26b #1415
Conversation
fix find_program call
@halx99 can we merge this PR? |
This PR will break android device compatibility, so I add to next milestone. |
What do you mean by "break android device compatibility"?
|
means build apk with ndk-r25+ can't runs on android 4.2 devices |
Wouldn't it be better to keep the NDK at the lowest possible version to not limit any devices? There is support in the build scripts to change the version used by passing it at the command line. |
for example: axmol build -p android -a arm64 -cc ndk-r25c |
r26b is the latest supported version - LTS Version. I think that official axmol configuration by default should be build based on officially supported libraries. If someone need to support older versions 4.2, 4.1 3.0 android then probably "-cc ndk-r25c" or older can be used |
sorry, i don't agree, axmol was tested with ndk-r23c, and works well, new devices related to sdk platform, usually not limit ndk versions. I also have check the latest unity 2023, it use ndk-r23b.
we should keep it except there are critical issues of it(crashing, generating incorrect code, ...)
获取Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: CHP ***@***.***>
Sent: Thursday, November 2, 2023 11:23:58 PM
To: axmolengine/axmol ***@***.***>
Cc: Deal ***@***.***>; Mention ***@***.***>
Subject: Re: [axmolengine/axmol] Android update NDK to latest version ndk26b (PR #1415)
r26b is the latest supported version - LTS Version.
All other NDK versions are not officially supported any more:
Please check https://github.com/android/ndk/wiki/Unsupported-Downloads
Using unsuported NDK is gray zone (will it work with latest android version? will it work with other android libraries?)
I think that official axmol configuration by default should be build based on officially supported libraries. If someone need to support older versions 4.2, 4.1 3.0 android then probably "-cc ndk-r25c" or older can be used
―
Reply to this email directly, view it on GitHub<#1415 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABVHOJZWM6DA7CWVLJP3HATYCO3I5AVCNFSM6AAAAAA6ZJ37DGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJQHE2TAMRRGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
maybe after 3-5 years, we can update ndk |
@@ -97,7 +97,7 @@ class axutils { | |||
// } | |||
|
|||
@SuppressWarnings('unused') | |||
static String[] findNativeBuildTools(project, cmakeVer = "3.22.1+", ndkVer = "23.2.8568313") { | |||
static String[] findNativeBuildTools(project, cmakeVer = "3.22.1+", ndkVer = "26.1.10909125") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should also change api leve in all gradle projects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. API changed to 21.
I did it once 0585fe5 but it was reverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. API changed to 21. I did it once 0585fe5 but it was reverted
yes, because when i build apk, can't install to android 4.2 emulator for testing GLESv2 compatibility.
NDK maintainers recommend to use always latest NDK. Google Play services discontinuing updates for KitKat (API levels 19 & 20) starting August 2023 I understand that for some developers support ~10 years old devices and android 4.4 KitKat (~0.4%) can be required but I think that for most of us supporting devices that are officially supported by Google is the way to go. |
3.x will update ndk to r27c |
Which branch your pull-request should merge into?
dev
: Current 2.x BugFixs or FeaturesDescribe your changes
Android update NDK to latest version ndk26b
Issue ticket number and link
Checklist before requesting a review