-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change extension folder structure to reduce file name conflicts #1647
Conversation
There are issues with the LUA bindings generator, so attempting to fix that in order to complete this PR. |
The LUA binding generator should be working now. If there are any concerns or suggestions, then I'll get around to having a look at them in 2 days time. |
lgtm |
Hold off on any merging. One last thing to do, which is fixing the pre-built paths in EDIT: All done. Commit d894c54 should also fix the issue with yasio that has been reported on the Discord server (missing header search path and linker error with pre-builts). |
Set correct paths to extensions for prebuilt option
Which branch your pull-request should merge into?
2.1
: BugFixes and Improvements for Current LTS branchDescribe your changes
Moved each extension into its own "src" folder.
Each extension
CMakeList.txt
now sets up the include paths for that extension.LUA bindings generator updated, but this needs to be checked.
Fix issue with detecting Effekseer and DrawNodeEx extensions in cpp-tests.
Note that I manually updated the auto-generated lua bindings, so I haven't yet tested the changes to the LUA binding generator to see if it does generate the correct output. Hopefully that is the case, but if not, then any help with that specific part would be appreciated.
It seems that a few existing issues surfaced when the extension folder structure was changed, such as header files to inactive extensions being included when they shouldn't be.
FYI, the changes in this PR shouldn't break any existing code. If anything, it would be a few include statements that would need to be fixed up in a project, assuming it uses extensions.
Issue ticket number and link
#1645
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."
I have performed a self-review of my code.
Optional:
For core/new feature PR