Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross fade transition #1664

Merged
merged 2 commits into from
Feb 10, 2024
Merged

Conversation

rh101
Copy link
Contributor

@rh101 rh101 commented Feb 10, 2024

Which branch your pull-request should merge into?

  • 2.1: BugFixes and Improvements for Current LTS branch

Describe your changes

This is related to the issue described in #1663 with the cross-fade transition. The render textures used for the transition cannot use a shared render target. It's reproducible with the cpp-tests project (test menu 64: Transitions, test 8).

Issue ticket number and link

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

@aismann
Copy link
Contributor

aismann commented Feb 10, 2024

@rh101
Plz add the copyright line too:
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

Thanks.

@halx99 halx99 added this to the 2.1.2 milestone Feb 10, 2024
@halx99 halx99 added the bug Something isn't working label Feb 10, 2024
@halx99 halx99 merged commit d8df9fb into axmolengine:2.1 Feb 10, 2024
@rh101 rh101 deleted the crossfade-transition-fix branch February 10, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants