Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on iOS #1799

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Fix crash on iOS #1799

merged 1 commit into from
Apr 8, 2024

Conversation

smilediver
Copy link
Contributor

Describe your changes

This fixes the following crash on iOS: https://stackoverflow.com/questions/55361057/this-copy-of-libswiftcore-dylib-requires-an-os-version-prior-to-12-2-0

Issue ticket number and link

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

@halx99
Copy link
Collaborator

halx99 commented Apr 8, 2024

why need /usr/lib/swift, axmol not use swift

@smilediver
Copy link
Contributor Author

smilediver commented Apr 8, 2024

We use CocoaPods and some pods use Swift, for example Firebase. "/usr/lib/swift" is added by the pods xcconfig file to fix this issue, but CMAKE_INSTALL_RPATH set by Axmol sets this on the app target and inserts the "@executable_path/Frameworks" before the pod xcconfig overriding the value.

Screenshot 2024-04-08 at 17 25 34

@halx99 halx99 merged commit 2493a6d into axmolengine:dev Apr 8, 2024
13 of 15 checks passed
@smilediver smilediver deleted the fix_ios_crash branch April 9, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants