-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark AXLOG, AXLOGINFO, AXLOGWARN, AXLOGERROR deprecated #2017
Conversation
c3ede55
to
2f812af
Compare
I have mostly used AXLOG, so I should shift to ax::print I guess. |
ax::print also deprecated, you can still use them until axmol 2.2.x |
What do we use now?. |
@johnspeny you need use AXLOGD, AXLOGW, AXLOGE, etc. |
Didn't know they existed, nice work. |
@halx99 This change has resulted in a lot of log spam, such as the following:
Can we please have these use AXLOGV instead of AXLOGD/AXLOGI?
Is the |
Yes, should use |
Describe your changes
Remove all old log macro calls from
core
folder, instead use c++20 format style macros: AXLOGD, AXLOGI, AXLOGW, AXLOGE.Issue ticket number and link
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."
I have performed a self-review of my code.
Optional:
For core/new feature PR