[ImGui] Allow setting of custom font config to enable merging of multiple fonts and other features #2085
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
When adding multiple fonts to ImGui, the only way to merge fonts is to set the
ImFontConfig::MergeMode = true
, otherwise glyphs from additional fonts do not render correctly.This change allows custom
ImFontConfig
to be set on a font that is added viaImGuiPresenter::addFont
. This change does not affect existing usage of theImGuiPresenter::addFont
method, because thefontConfig
parameter has a default value ofImFontConfig()
. The default value is valid, since it is what ImGui does internally if anullptr
is passed to one of theImGui::AddFontXYZ
methods.For example:
Issue ticket number and link
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."
I have performed a self-review of my code.
Optional:
For core/new feature PR