Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix continues drawCardinalSplines() drawing outside the control points on last control point #2303

Merged
merged 2 commits into from
Jan 5, 2025
Merged

Fix continues drawCardinalSplines() drawing outside the control points on last control point #2303

merged 2 commits into from
Jan 5, 2025

Conversation

aismann
Copy link
Contributor

@aismann aismann commented Jan 4, 2025 •
edited
Loading

Describe your changes

Fix for issue #2302

image

Issue ticket number and link

#2302

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

@aismann aismann changed the title Fix for issue #2302 Fix for issue #2302: Cocos2d-x 3.x BUG: Continues drawCardinalSplines() drawing outside the control points on last control point Jan 4, 2025
@aismann aismann changed the title Fix for issue #2302: Cocos2d-x 3.x BUG: Continues drawCardinalSplines() drawing outside the control points on last control point FIX: Cocos2d-x 3.x BUG: Continues drawCardinalSplines() drawing outside the control points on last control point Jan 4, 2025
@aismann
Copy link
Contributor Author

aismann commented Jan 4, 2025

@halx99
Its ready for merge

@halx99 halx99 changed the title FIX: Cocos2d-x 3.x BUG: Continues drawCardinalSplines() drawing outside the control points on last control point Fix Continues drawCardinalSplines() drawing outside the control points on last control point Jan 5, 2025
@halx99 halx99 changed the title Fix Continues drawCardinalSplines() drawing outside the control points on last control point Fix continues drawCardinalSplines() drawing outside the control points on last control point Jan 5, 2025
@halx99 halx99 merged commit baf9083 into axmolengine:dev Jan 5, 2025
15 checks passed
@halx99 halx99 added this to the 2.3.1 milestone Jan 5, 2025
@halx99 halx99 linked an issue Jan 5, 2025 that may be closed by this pull request
Cocos2d-x 3.x BUG: Continues drawCardinalSplines() drawing outside the control points on last control point #2302
Closed
halx99 pushed a commit that referenced this pull request Jan 5, 2025
@aismann @halx99
Fix continues drawCardinalSplines() drawing outside the control point…
16ff7c7 
…s on last control point (#2303)

* Fix for issue #2302

* Codacy Static Code Analysis fix
@aismann aismann deleted the Issue_#2302 branch January 5, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.

Cocos2d-x 3.x BUG: Continues drawCardinalSplines() drawing outside the control points on last control point
2 participants
@aismann @halx99