Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DevSetup.md for Android #2319

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Update DevSetup.md for Android #2319

merged 1 commit into from
Jan 9, 2025

Conversation

rh101
Copy link
Contributor

@rh101 rh101 commented Jan 9, 2025

Describe your changes

The instructions in the DevSetup state that r23c is the minimum, which may make developer assume that it would be set as the default, which is not the case, since the default configured NDK is r23d in https://github.com/axmolengine/axmol/blob/dev/1k/build.profiles#L46

To avoid this confusion, instructions have been updated to ensue developers run the setup.ps1 -p android in order to download NDK r23d, just so that they can get up and running with a new project without issues.

Issue ticket number and link

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

@rh101
Copy link
Contributor Author

rh101 commented Jan 9, 2025

@halx99 There may be an issue on MacOS. If setup.ps1 is run first, then setup.ps1 -p android is run afterwards, it does not download the NDK. It's happened to a few developers so far, and all seem to be using MacOS. Could there be something that is preventing the command from running correctly (such as a cached value etc.)?

@halx99 halx99 added this to the 2.3.2 milestone Jan 9, 2025
@halx99 halx99 added the documentation Improvements or additions to documentation label Jan 9, 2025
@halx99 halx99 merged commit 821e81c into dev Jan 9, 2025
1 check passed
@halx99 halx99 deleted the rh101-patch-1 branch January 9, 2025 13:08
@halx99
Copy link
Collaborator

halx99 commented Jan 9, 2025

@halx99 There may be an issue on MacOS. If setup.ps1 is run first, then setup.ps1 -p android is run afterwards, it does not download the NDK. It's happened to a few developers so far, and all seem to be using MacOS. Could there be something that is preventing the command from running correctly (such as a cached value etc.)?

I will take a look

@rh101
Copy link
Contributor Author

rh101 commented Jan 9, 2025

Sorry, I didn't realise it created the branch in this repo instead mine, so I'll pay more attention to that next time.

@halx99
Copy link
Collaborator

halx99 commented Jan 9, 2025

@halx99 There may be an issue on MacOS. If setup.ps1 is run first, then setup.ps1 -p android is run afterwards, it does not download the NDK. It's happened to a few developers so far, and all seem to be using MacOS. Could there be something that is preventing the command from running correctly (such as a cached value etc.)?

I will take a look

I can't reproduce it

@rh101
Copy link
Contributor Author

rh101 commented Jan 9, 2025

I can't reproduce it

OK! Then it may just be a configuration issue in their own environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants